fix: Remove orphaned volumes after make dev-int and ci-int - #2970
fix: Remove orphaned volumes after make dev-int and ci-int#2970pulpdrew wants to merge 1 commit into
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Deep Review✅ No critical issues found. This PR adds The change is correct and low-risk:
The 2 prior comments are automated bot notifications (changeset-bot, vercel-bot) with no substantive feedback to address. Reviewers (4): correctness, data-integrity, project-standards, previous-comments Testing gaps: None — Makefile-only tooling change with no application code; no test coverage warranted. |
Greptile SummaryThis PR updates local integration-test teardown to remove project-scoped anonymous Docker volumes after services stop.
Confidence Score: 5/5The PR appears safe to merge because teardown removes only project-scoped anonymous volumes while integration logs remain on the host. The CI Compose configuration has no named or external volumes, existing teardown already removes container-local test data, and archived logs are stored outside Docker volumes.
|
| Filename | Overview |
|---|---|
| Makefile | Adds anonymous-volume cleanup to four Docker Compose teardown paths without affecting persisted logs or unrelated named volumes. |
Reviews (1): Last reviewed commit: "fix: Remove orphaned volumes after make ..." | Re-trigger Greptile
E2E Test Results✅ All tests passed • 307 passed • 1 skipped • 1049s
Tests ran across 4 shards in parallel. |
Summary
This PR updates the
make dev-intandmake ci-intso that the anonymous volumes that they create duringdocker compose upare removed duringdocker compose down. New volumes are created each time me or my agents run these commands, and add up to a significant amount of disk space after some time.Screenshots or video
How to test on Vercel preview
No application changes.
Do
make dev-intlocallyReferences