Skip to content

fix: Remove orphaned volumes after make dev-int and ci-int - #2970

Open
pulpdrew wants to merge 1 commit into
mainfrom
drew/remove-volumes
Open

fix: Remove orphaned volumes after make dev-int and ci-int#2970
pulpdrew wants to merge 1 commit into
mainfrom
drew/remove-volumes

Conversation

@pulpdrew

Copy link
Copy Markdown
Contributor

Summary

This PR updates the make dev-int and make ci-int so that the anonymous volumes that they create during docker compose up are removed during docker compose down. New volumes are created each time me or my agents run these commands, and add up to a significant amount of disk space after some time.

Screenshots or video

How to test on Vercel preview

No application changes.

Do make dev-int locally

References

  • Linear Issue:
  • Related PRs:

@changeset-bot

changeset-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c662990

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hyperdx-oss Ignored Ignored Aug 21, 2026 6:53pm
hyperdx-storybook Ignored Ignored Aug 21, 2026 6:53pm

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Aug 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 8
  • Branch: drew/remove-volumes
  • Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This PR adds -v to docker compose down in the CI/integration Make targets (dev-int-down, dev-int, dev-int-common-utils, ci-int) so the anonymous volumes created by the mongo and clickhouse images are torn down instead of orphaned.

The change is correct and low-risk:

  • Every affected command is scoped with -p $(HDX_CI_PROJECT), so -v only removes volumes belonging to this ephemeral CI project and cannot touch other projects' data.
  • docker-compose.ci.yml declares no named volumes (only bind mounts and a network), so -v targets only the anonymous image-declared volumes — exactly the orphaned volumes being cleaned up.
  • These are throwaway integration/CI databases recreated fresh on each up -d; anonymous volumes were never reattached across down/up cycles, so there is no state-reuse regression — the prior behavior only leaked disk.
  • The change aligns the CI targets with the pre-existing dev-e2e-down target (Makefile:133), which already used down -v.

The 2 prior comments are automated bot notifications (changeset-bot, vercel-bot) with no substantive feedback to address.


Reviewers (4): correctness, data-integrity, project-standards, previous-comments

Testing gaps: None — Makefile-only tooling change with no application code; no test coverage warranted.

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates local integration-test teardown to remove project-scoped anonymous Docker volumes after services stop.

  • Adds -v to the explicit dev-int-down target.
  • Applies the same cleanup to API, common-utils, and combined integration-test targets.
  • Preserves test exit codes and host-based log archival behavior.

Confidence Score: 5/5

The PR appears safe to merge because teardown removes only project-scoped anonymous volumes while integration logs remain on the host.

The CI Compose configuration has no named or external volumes, existing teardown already removes container-local test data, and archived logs are stored outside Docker volumes.

Important Files Changed

Filename Overview
Makefile Adds anonymous-volume cleanup to four Docker Compose teardown paths without affecting persisted logs or unrelated named volumes.

Reviews (1): Last reviewed commit: "fix: Remove orphaned volumes after make ..." | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 307 passed • 1 skipped • 1049s

Status Count
✅ Passed 307
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant