[HDX-4235] ci: remove cancel-in-progress from push.yml#2281
Draft
wrn14897 wants to merge 1 commit into
Draft
Conversation
… ports (HDX-4235) The Push Downstream workflow uses createWorkflowDispatch to mirror each push to main as a downstream EE port. Each run is a single short API call, so there is no benefit to cancelling in-flight runs. The previous `cancel-in-progress: true` setting created a race where a queued run could be cancelled (and silently skipped entirely) instead of running after the active one finished. This dropped the EE port for at least one merge commit: - f6a1d02 (PR #2250, feat(mcp): add event_patterns display type to query tool) which had to be ported manually as hyperdxio/hyperdx-ee#2073. Removing the concurrency block ensures every push to main spawns its own downstream dispatch, even when pushes land close together.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
wrn14897
added
the
ai-generated
Contributor
E2E Test Results✅ All tests passed • 178 passed • 3 skipped • 1265s
Tests ran across 4 shards in parallel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Push Downstreamworkflow (.github/workflows/push.yml) usescreateWorkflowDispatchto fan a downstream EE port out for every push tomain. Each run is a single short API call, so there is no benefit tocancelling in-flight runs.
The previous
concurrency.cancel-in-progress: truesetting created a racewhere a queued run could be cancelled (and silently skipped entirely)
instead of running after the active one finished. This dropped the EE port
for at least one merge commit:
f6a1d0213127bd845fc4cba47fd70d54ce0874dc— PR feat(mcp): add event_patterns display type to query tool #2250(
feat(mcp): add event_patterns display type to query tool,Linear HDX-4142). The downstream port had to be done manually as
hyperdxio/hyperdx-ee#2073,
and a follow-up fix was needed for a regression that landed in the gap
(HDX-4247).
This PR removes the
concurrencyblock entirely so every push tomainspawns its own downstream dispatch, even when pushes land close together.
A YAML comment is added in its place explaining the intent so the setting
isn't reintroduced.
This implements remediation option #3 from HDX-4235.
Screenshots or video
N/A — non-UI change.
How to test on Vercel preview
N/A — non-UI change.
References