-
Notifications
You must be signed in to change notification settings - Fork 348
feat: Add dashboard tile tags for organization and filtering #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 329e833 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@alok87 is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
|
Some bug - fixing. |
|
Fixed. Updated Video and Image also. |
| w: number; | ||
| h: number; | ||
| config: SavedChartConfig; | ||
| tags?: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alok87 can we separate these PRs so there are two? One for the DBTimeChart legend feature, and one for the dashboard tile tags? These feel like separate concerns.
Additionally, is it possible to run yarn changeset to generate a changeset for the two features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! ✅ I've split this PR into two separate PRs:
PR #1572: Chart Legend Series Filtering (Merge First)
#1572
- Chart legend series filtering feature
- Changes to
HDXMultiSeriesTimeChart.tsxandDBTimeChart.tsx
PR #1568: Dashboard Tile Tags (This PR - Merge Second)
- Dashboard tile tags feature
- Changes to
DBDashboardPage.tsx,types.ts, anddashboard.ts - Now builds on top of feat: Add chart legend series filtering #1572
The PRs are now separated by concern and can be reviewed/merged independently. Will add changesets next!
ba87e00 to
5b53316
Compare
- Click on legend labels to show only that series in the chart - Shift+Click to select multiple series for comparison - All legend items remain visible with clear visual feedback: - Selected: Bold font, thick line, full opacity - Non-selected: Dimmed (30% opacity) but still visible - Click selected item again to clear filter and show all series - Auto-scale Y-axis when filtering chart series to fit visible data Part of hyperdxio#1558
- Add tags field to dashboard tiles for better organization - Tiles can be tagged in the edit modal - Click on tile tags to filter the dashboard view - Visual filter indicator shows active tag filter - URL state preservation for sharing filtered views Part of hyperdxio#1558
656f30c to
7919268
Compare
…ent layout issues
…s instead of removing from DOM
|
This is not working, could not give more time but @brandon-pereira do evaluate if it can be brought in, as suppose in my dashboards i have many tiles and they have tags, if i click on some tag during troubleshooting all my tiles disappears and only those tag tiles remain. Please take this forward if you folks align. |
Changes
This PR implements dashboard tile tags feature as part of #1558.
Features
Dashboard Tile Tags & Filtering
tagsfield to dashboard tiles for organizationHow It Works
Technical Changes
TileSchemain common-utils to include optional tags fieldDBDashboardPageto support tag filtering with URL statePart of #1558