-
Notifications
You must be signed in to change notification settings - Fork 335
feat: adjust alert template title and body to reflect alert state #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3e6ae6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: Alert Template State Awareness✅ Overall assessment: Implementation is solid with good test coverage. Critical IssuesNone found. Code Quality Observations✅ Strengths:
|
E2E Test Results✅ All tests passed • 39 passed • 3 skipped • 288s
|
83962d4 to
80ff37e
Compare
pulpdrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently, the resolved alert will have the same title and body message as the alerting one, which is misleading
Ref: HDX-2786
Slack
ALERT
RESOLVED
incident.io
ALERT
RESOLVED