Repository navigation
Conversation
rmccue
requested changes
Nov 2, 2026
Comment on lines
+118
to
+120
| <noscript> | ||
| <p><?php esc_html_e( 'JavaScript is required to use the checklist controls. You can still read all steps below.', 'process-blocks' ); ?></p> | ||
| </noscript> |
Member
There was a problem hiding this comment.
If the info here is just "you can't see a thing but it works otherwise", I don't think this is really adding anything. Can we just hide anything that doesn't work for no-js instead?
| if ( next === -1 ) { | ||
| context.announcement = state.i18n.finished; | ||
| // The completion button disappears; focus its replacement after rendering. | ||
| yield new Promise( resolve => window.requestAnimationFrame( resolve ) ); |
Member
There was a problem hiding this comment.
Can't say I love these generators; they hurt the readability of the code. Is there no better way to achieve this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Written by Codex
gpt-6.1-sol high