Restore the smoke script lost in a package.json merge - #51
Merged
Merged
Conversation
CI and the release workflow both run npm run smoke, but since PR #45 merged npm reports "Missing script: smoke". That PR was branched before the release process existed and added its own scripts block with only test. Merging it onto main left package.json with two scripts keys, and JSON parsing keeps the last one, so smoke silently disappeared while scripts/smoke.js stayed in the tree. Collapse to a single scripts block with both entries. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
filter182
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every push to main and every release since 11 Sep fails at the smoke step with
npm error Missing script: "smoke". The 1.1.1 release never made it to npm because of this.PR #45 was branched in July, before the release process existed, and added its own
scriptsblock containing onlytest. When it merged onto main, which already hadscripts.smoke, the result was a package.json with twoscriptskeys. JSON parsing keeps the last one, sosmokewas silently dropped whilescripts/smoke.jsstayed in the tree. The Tests workflow kept passing becausetestsurvived, which hid the problem.This collapses the duplicate into one block with both
testandsmoke. Verified locally thatnpm run smokerenders the full help output and exits 0.🤖 Generated with Claude Code
This PR was posted by AI on Joe's behalf.