Fix crash in device_map='auto' when CPU is missing from inferred max_memory #43013
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a crash when using
device_map="auto"in environments where"cpu"is missing from the inferredmax_memorydictionary.Bug
When
max_memoryis not explicitly provided,accelerate.get_max_memory()may return a dictionary without a"cpu"key (depending on the backend/environment)._get_device_mapthen unconditionally scales"cpu"memory, resulting in aKeyError.Fix
"cpu"ininferred_max_memorybefore applying the scaling factor."cpu"is present.Tests
tests/utils/test_device_map_cpu_guard.pyto ensuredevice_map="auto"does not crash when"cpu"is absent frommax_memory.Fixes #42994
Before submitting
Who can review?
@Cyrilvallez