[fix:]: initialize ModernBertUnpaddedRotaryEmbedding when loading from a checkpoint
#42998
+70
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fix improves accuracy and prevents existing ModernBert models from yielding NaN tensors. Previously, when a pretrained modernbert model is loaded, the
ModernBertUnpaddedRotaryEmbedding'sinv_freqnon-persistent buffer is not initialized resulting inNaNloss and logits.Without fix:
ModernBertForSequenceClassificationModernBertModelIntegrationTest.test_inference_sequence_classification_flash_attention_2rarely returns NaN tensors but instead fails due to inaccurate logitsModernBertModelIntegrationTest.test_inference_sequence_classification_flash_attention_2_modernbert_basealways fails due to NaN logits.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @Cyrilvallez