-
Notifications
You must be signed in to change notification settings - Fork 31.5k
fix failure of llava/pixtral #42985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix failure of llava/pixtral #42985
Conversation
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
output "DescribeĠtheĠimages", expected output "Describe the images"(in transformers 4.57.3) |
|
also, fix the failure in llava test |
|
Mistral3ProcessorTest case fail because the tokenizer fix. |
|
seems the pre_tokenizer should be loaded from tokenizer.json, but in v5.0.0, it does not do it. |
|
Normally #42894 should fix tokenization issues on main and on the next release candidate. Might need some time with the holiday season now, apologies.There are a few different changes on your PR, can you put what fails in the PR description and ensure your PR fixes minimally? Thanks! |
Hi, I tried #42894, but it does not fix the "hf-internal-testing/Mistral-Small-3.1-24B-Instruct-2503-only-processor" and "mistral-community/pixtral-12b" issue, The issue is that nearly all cases of pytest tests/models/llava/test_modeling_llava.py::LlavaForConditionalGenerationIntegrationTest fail, because of tokenizer issue and case issue, and I fix them. |
…sor tokenizer Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
|
[For maintainers] Suggested jobs to run (before merge) run-slow: llava, pixtral |
|
@molbap I update the PR to fix all the issue I mentioned in the PR including llava test, tokenizer issue of mistral-community/pixtral-12b and hf-internal-testing/Mistral-Small-3.1-24B-Instruct-2503-only-processor |
What does this PR do?