Fix relational comparisons with different condition counts - #1349
Open
Excelius-Wang wants to merge 1 commit into
Open
Fix relational comparisons with different condition counts#1349Excelius-Wang wants to merge 1 commit into
Excelius-Wang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent chained inequalities with different numbers of relations from being treated as equivalent.
zip()previously compared only the shared pairs, soa < b < ccould matcha < b < c < d. The comparison now requires both values to be conjunctions with the same number of conditions before comparing each relation.Testing
pytest tests/unit/metrics/test_extractive_match.py -q— 235 passedpytest tests/unit/metrics -q -k "not bleurt and not extractiveness and not pmi_request"— 284 passedruff format --check src/lighteval/metrics/utils/math_comparison.py tests/unit/metrics/test_extractive_match.pyruff check src/lighteval/metrics/utils/math_comparison.py tests/unit/metrics/test_extractive_match.py