Skip to content

feat: prefer unique e2e ci repo rather than branch#573

Open
drbh wants to merge 1 commit into
mainfrom
restructure-e2e-workflow
Open

feat: prefer unique e2e ci repo rather than branch#573
drbh wants to merge 1 commit into
mainfrom
restructure-e2e-workflow

Conversation

@drbh
Copy link
Copy Markdown
Collaborator

@drbh drbh commented May 20, 2026

This PR restructures the e2e workflow to write to a unique repo id per run id and run attempt rather than a fixed repo id. This has the benefit of avoiding conflicts of writing to the same repo, and removes the need to add a concurrency group to handle possible race condition. These changes ensure that a each ci job will create a new repo and push, test it works, then clean up the repo at the end of the workflow.

Copy link
Copy Markdown
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More reliable indeed.

Copy link
Copy Markdown
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems to have surfaced an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants