Add source to metadata#572
Open
drbh wants to merge 4 commits into
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
danieldk
reviewed
May 20, 2026
Member
danieldk
left a comment
danieldk
left a comment
There was a problem hiding this comment.
Nice!!! Added some comments on the docs.
Comment on lines
+193
to
+197
| - `upstream`: URL of the original upstream repository where the kernel | ||
| source code comes from. | ||
| - `source`: URL of the kernel-builder formatted source repository. This | ||
| repository must contain a `build.toml` and `flake.nix` so that it can be | ||
| pulled and built with the kernel builder. |
Member
There was a problem hiding this comment.
In both cases, I think we should say something about the format. Should this be a URL that can be passed directly to git? What about Git over SSH?
Member
There was a problem hiding this comment.
Now saw GitUrl below, so I think good to mention here that these should be Git-compatible (passable to git clone).
Comment on lines
+74
to
+77
| - `upstream` (`str`, optional): URL of the original upstream repository | ||
| where the kernel source code comes from. | ||
| - `source` (`str`, optional): URL of the kernel-builder formatted source | ||
| repository (must contain `build.toml` and `flake.nix`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional
sourceattribute to the metadata struct, thissourceis different thanupstreamsince it is intended to point to the kernel builder compliant source related to the kernel. This distinction is important since theupstreammay not originally be formatted in a way that the kernel-builder can compile - yet we want to be able to indicate the original code, and the code used to compile the kernel.Note this PR also adds a step to validate the
upstreamand thesourcefields to be git urls