[tests] refactor a* pipeline tests. - #14622
Open
sayakpaul wants to merge 4 commits into
Open
Conversation
Member
Author
|
/diffusers-bot pytest tests/pipelines/animatediff/test_animatediff_sdxl.py |
Contributor
|
✅ |
Conflict: tests/pipelines/stable_diffusion/ip_adapter_tester.py was moved to tests/pipelines/testing_utils/ip_adapter.py on this branch while main edited its docstring (#14619). Kept this branch's wording, which already covers main's intent now that the mixin is shared rather than SD-local. Resolution beyond the conflict markers: #14619 added `from ..stable_diffusion.ip_adapter_tester import IPAdapterTesterMixin` to four stable_diffusion_xl test files. That path no longer exists, so they now import IPAdapterTesterMixin from ..testing_utils like the stable_diffusion ones. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Conflict: tests/pipelines/stable_diffusion/test_stable_diffusion.py — both sides added entries to the same `..testing_utils` import block. #14559 inlined the tests/lora/test_lora_layers_sd.py suite (LoraTesterMixin, LoraMemoryTesterMixin) while this branch added IPAdapterTesterMixin from the promoted shared mixin. Took the union; all five are used by classes in the file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The `test_dict_tuple_outputs_equivalent` override ported in e10f8d0 carried a nine-value expected slice that is not the one the pre-migration file used, so CI failed on CPU with `Shape mismatch: actual torch.Size([6]) vs expected torch.Size([9])`. Six is correct: the base test slices `output_tuple[0, -3:, -3:, -1, -1]` and this pipeline's dummy inputs use `num_frames=2`, so the frame axis yields 2 rather than 3. Restored the original values, unchanged since #14120. The literal is only read when `torch_device == "cpu"`, which is why local GPU runs did not catch it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor remaining A* pipeline tests. Including deleting the respective
tests/lora/test_lora_layers_*.pyfiles, too where relevant as we use the newly addedtests/pipelines/testing_utils/lora.pytester mixin.