Fix batching and precomputed embeddings in Kandinsky 5 pipelines#14168
Draft
pzarzycki wants to merge 1 commit into
Draft
Fix batching and precomputed embeddings in Kandinsky 5 pipelines#14168pzarzycki wants to merge 1 commit into
pzarzycki wants to merge 1 commit into
Conversation
Contributor
Author
|
While running the full Kandinsky 5 test suite on CUDA, I noticed that the generic I reproduced both failures on a clean checkout of the same I have two ideas:
What do you think? CUDA fp32 and bf16-autocast inference pass for all four Kandinsky 5 pipelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Kandinsky 5 pipelines expanded the latent batch for
num_images_per_promptandnum_videos_per_prompt, but did not always expand the matching text and visual conditioning. This caused batch mismatches when generating multiple outputs, especially when callers supplied precomputed prompt embeddings.This PR makes batching consistent across the T2I, I2I, T2V, and I2V pipelines. It:
prompt=None;num_videos_per_promptthrough the T2V text-encoding path;Focused regression tests cover all four pipelines. This addresses the batching and precomputed-embedding findings in #13639.
Tests
122 passed, 16 skipped, 4 deselected9 passedmake fix-copiespython -m compileall -q src/diffusers/pipelines/kandinsky5 tests/pipelines/kandinsky5git diff --checkBefore submitting
.ai/review-rules.md?Who can review?
@yiyixuxu @asomoza