Skip to content

[lora training] add caption dropout and aspect ratio buckets to krea2 and qwen-image#14089

Open
linoytsaban wants to merge 2 commits into
mainfrom
lora-caption-dropout-ar-buckets
Open

[lora training] add caption dropout and aspect ratio buckets to krea2 and qwen-image#14089
linoytsaban wants to merge 2 commits into
mainfrom
lora-caption-dropout-ar-buckets

Conversation

@linoytsaban

@linoytsaban linoytsaban commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Adds aspect-ratio bucketing and caption dropout to the krea2 and qwen-image dreambooth LoRA scripts (neither supported these before):

  • Aspect-ratio bucketing for krea2 and qwen-image.
  • Caption dropout (--caption_dropout): randomly replace an instance caption with "" so that fraction trains unconditionally (improves CFG).
  • --bucket_no_upscale: pad images smaller than their bucket instead of upscaling; class/prior-preservation images are bucketed too.

Split from the original PR; bucketing fixes to the other scripts that already support buckets are in #14158.

@github-actions github-actions Bot added examples size/L PR with diff > 200 LOC labels Jun 29, 2026
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@linoytsaban linoytsaban force-pushed the lora-caption-dropout-ar-buckets branch from a539d74 to 975986d Compare June 30, 2026 09:09
@linoytsaban

Copy link
Copy Markdown
Collaborator Author

krea comparison with and without buckets and dropout
image

@linoytsaban linoytsaban marked this pull request as ready for review June 30, 2026 11:56
@linoytsaban linoytsaban requested a review from sayakpaul June 30, 2026 11:56

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do it just one and then propagate to the others? This way, it's easier to review.

@linoytsaban

Copy link
Copy Markdown
Collaborator Author

Should we do it just one and then propagate to the others? This way, it's easier to review.

I can split the krea 2 + qwen image changes (that introduce aspect ratio buckets + caption dropout since they dont currently support these at all) from the changes to the other scripts (that already support bucketing) where it's fixing bucketing issues. wdyt?

@sayakpaul

Copy link
Copy Markdown
Member

Yes sure

@linoytsaban linoytsaban force-pushed the lora-caption-dropout-ar-buckets branch from 098cc5b to 25d9f73 Compare July 10, 2026 08:35
@linoytsaban linoytsaban changed the title [lora training] add caption dropout and aspect ratio buckets [lora training] add caption dropout and aspect ratio buckets to krea2 and qwen-image Jul 10, 2026
@linoytsaban linoytsaban requested a review from sayakpaul July 10, 2026 10:28

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as the other PR. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples size/L PR with diff > 200 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants