-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1 #9882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-REMIXRUNROUTER-14908530 - https://snyk.io/vuln/SNYK-JS-REACTROUTER-14908286 - https://snyk.io/vuln/SNYK-JS-REMIXRUNROUTER-14908287
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sequence Diagram
This diagram shows the interactions between components:
sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant WS as Workspace
participant NPM as NPM Registry
participant Plugin as Splunk-on-Call Plugin
Note over Dev,Plugin: Dependency Resolution Change
Dev->>PM: Install dependencies for splunk-on-call plugin
alt Before Change (workspace:^)
PM->>WS: Resolve @backstage/theme from workspace
WS-->>PM: Return local workspace version
PM->>Plugin: Link workspace theme package
else After Change (0.1.1)
PM->>NPM: Fetch @backstage/theme@0.1.1
NPM-->>PM: Return published version 0.1.1
PM->>Plugin: Install pinned theme version
end
Note over Plugin: Plugin now uses fixed theme version<br/>instead of workspace reference
Install the extension
Note for Windsurf
Please change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery
Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items
Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below
Emoji Descriptions:
⚠️ Potential Issue - May require further investigation.- 🔒 Security Vulnerability - Fix to ensure system safety.
- 💻 Code Improvement - Suggestions to enhance code quality.
- 🔨 Refactor Suggestion - Recommendations for restructuring code.
- ℹ️ Others - General comments and information.
Interact with the Bot:
- Send a message or request using the format:
@entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
- Help the Bot learn by providing feedback on its responses.
@entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !
Also you can trigger various commands with the bot by doing
@entelligenceai command
The current supported commands are
config- shows the current configretrigger_review- retriggers the review
More commands to be added soon.
| "@backstage/core-components": "workspace:^", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/theme": "0.1.1", | ||
| "@material-ui/core": "^4.12.2", | ||
| "@material-ui/icons": "^4.9.1", | ||
| "@material-ui/lab": "4.0.0-alpha.61", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correctness: Line 6: Pinning @backstage/theme to 0.1.1 breaks monorepo resolution—all other deps use workspace:^. Revert to "@backstage/theme": "workspace:^".
🤖 AI Agent Prompt for Cursor/Windsurf
📋 Copy this prompt to your AI coding assistant (Cursor, Windsurf, etc.) to get help fixing this issue
File: plugins/splunk-on-call/package.json, Line 40
Problem: The dependency `@backstage/theme` has been changed from `workspace:^` to a pinned version `0.1.1`, breaking the monorepo workspace protocol used by all other Backstage dependencies in this file.
Fix Instructions:
1. Revert the change to use the workspace protocol
2. Change `"@backstage/theme": "0.1.1"` back to `"@backstage/theme": "workspace:^"`
3. This ensures consistency with other Backstage dependencies (@backstage/catalog-model, @backstage/core-components, @backstage/core-plugin-api, @backstage/plugin-catalog-react) which all use `workspace:^`
4. The workspace protocol ensures the local monorepo version is used during development and properly resolved during publishing
✨ Committable Code Suggestion
💡 This is a one-click fix! Click "Commit suggestion" to apply this change directly to your branch.
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/plugin-catalog-react": "workspace:^", | |
| "@backstage/theme": "workspace:^", | |
| "@backstage/theme": "0.1.1", | |
| "@material-ui/core": "^4.12.2", | |
| "@material-ui/icons": "^4.9.1", | |
| "@material-ui/lab": "4.0.0-alpha.61", | |
| "@backstage/catalog-model": "workspace:^", | |
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/plugin-catalog-react": "workspace:^", | |
| "@backstage/theme": "workspace:^", | |
| "@material-ui/core": "^4.12.2", | |
| "@material-ui/icons": "^4.9.1", | |
| "@material-ui/lab": "4.0.0-alpha.61", |
Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/splunk-on-call/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-REMIXRUNROUTER-14908530
SNYK-JS-REACTROUTER-14908286
SNYK-JS-REMIXRUNROUTER-14908287
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Open Redirect
🦉 Cross-site Scripting (XSS)