Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/techdocs-addons-test-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-search-react": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security: Critical security regression: Downgrading @backstage/plugin-techdocs from workspace:^ to version 0.1.1 (4+ years old) introduces numerous security vulnerabilities and compatibility issues

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs": "workspace:^",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: Breaking change: Version 0.1.1 from 2020 is completely incompatible with the current Backstage architecture, causing API incompatibilities and potential runtime failures

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs": "workspace:^",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security: Incorrect problem resolution: Downgrading to an ancient version is not the correct solution for the DOMPurify vulnerability SNYK-JS-DOMPURIFY-7984421

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs": "workspace:^",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Inconsistent dependency management pattern: All other dependencies use workspace:^ pattern, but this change uses a hardcoded version

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs": "workspace:^",

"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
Expand Down
Loading