Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize the media type inside the JSON formatter before its format-detection checks. Valid uppercase and mixed-case JSON types currently bypass formatting, including
Application/Problem+JSON. Response headers and payload content are unchanged.Two CLI-entry regressions reproduce the original failure; the JSON documentation now states case-insensitive media-type handling.
Validation: 417 tests pass, 3 expected failures, across test_json.py and test_output.py; Flake8 and diff checks pass. The suite's invalid-host test initially failed because the local proxy intercepted the request; it passes with proxy environment variables removed for that test process. Existing resource warnings remain. No full OS/Python matrix was run.
Self-review: limited to the JSON formatter, response regressions and its documentation. Authored with OpenAI Codex assistance.
Fixes #1958.
Remote CI note: the coverage job fails two Big5 charset-detection tests. Both failures also reproduce in an untouched checkout of base 5b604c3 with the same local dependency environment; they are outside this MIME-formatting change.