Skip to content

Fix case-sensitive detection of streaming event-stream responses #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harsh-thakkar7 wants to merge 1 commit into from
Closed

Fix case-sensitive detection of streaming event-stream responses #1955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion httpie/output/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def get_stream_type_and_kwargs(
raw_content_type_header = headers.get('Content-Type', None)
if raw_content_type_header:
content_type_header, _ = parse_content_type_header(raw_content_type_header)
is_stream = (content_type_header == 'text/event-stream')
is_stream = (content_type_header.lower() == 'text/event-stream')

if not env.stdout_isatty and not prettify_groups:
stream_class = RawStream
Expand Down
4 changes: 4 additions & 0 deletions tests/test_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ def test_redirected_stream(httpbin):
['Accept:text/event-stream; charset=utf-8'],
3
),
(
['Accept:Text/Event-Stream'],
3
),
(
['Accept:text/plain'],
1
Expand Down
Loading