Fixed URL-encoded characters in basic auth credentials (#1623) - #1936
Open
abhishekjoshi13 wants to merge 2 commits into
Open
Fixed URL-encoded characters in basic auth credentials (#1623)#1936abhishekjoshi13 wants to merge 2 commits into
abhishekjoshi13 wants to merge 2 commits into
Conversation
Author
|
HI team, just a quick heads up. The fix for decoding credentials in the URL is pushed and ready for review. I noticed the CI pipeline is throwing some failures, but after reviewing the server logs, they appear to be unrelated upstream issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When providing credentials in the URL that contain URL-encoded characters (like %40 for @), the urlsplit output was not being decoded before being passed to AuthCredentials. This resulted in the raw encoded string being Base64 encoded, causing server rejection. I injected urllib.parse.unquote in argparser.py to decode url.username and url.password prior to generating the Basic Auth headers