Skip to content

Fix #1623: Decode percent-encoded characters in URL credentials #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinayK34 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #1623: Decode percent-encoded characters in URL credentials #1931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions httpie/cli/argparser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import sys
from argparse import RawDescriptionHelpFormatter
from textwrap import dedent
from urllib.parse import urlsplit
from urllib.parse import urlsplit, unquote

from requests.utils import get_netrc_auth

Expand Down Expand Up @@ -291,6 +291,9 @@ def _process_auth(self):
# Handle http://username:password@hostname/
username = url.username
password = url.password or ''
# Decode percent-encoded characters in username and password
username = unquote(username)
password = unquote(password)
self.args.auth = AuthCredentials(
key=username,
value=password,
Expand All @@ -306,7 +309,7 @@ def _process_auth(self):
if (not self.args.ignore_netrc
and self.args.auth is None
and plugin.netrc_parse):
# Only host needed, so it’s OK URL not finalized.
# Only host needed, so it's OK URL not finalized.
netrc_credentials = get_netrc_auth(self.args.url)
if netrc_credentials:
self.args.auth = AuthCredentials(
Expand Down Expand Up @@ -377,7 +380,7 @@ def _apply_no_options(self, no_options):
invalid.append(option)

if invalid:
self.error(f'unrecognized arguments: {" ".join(invalid)}')
self.error(f'unrecognized arguments: {"".join(invalid)}')

def _body_from_file(self, fd):
"""Read the data from a file-like object.
Expand Down Expand Up @@ -610,4 +613,4 @@ def error(self, message):
'''.rstrip()
)
)
self.exit(2)
self.exit(2)
Loading