Fix #1828: Reduce cyclomatic complexity in argparser.py - #1930
Open
vinayK34 wants to merge 1 commit into
Open
Conversation
- Decomposed _process_auth method into 5 focused helper methods - Moved check_options function to class level - Added type annotations to methods - Reduced cyclomatic complexity from ~20 to ~5 per method - Eliminated duplicated code patterns
vinayK34
marked this pull request as ready for review
August 11, 2026 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1828 by reducing the cyclomatic complexity in
httpie/cli/argparser.py:Changes Made
Decomposed
_process_authmethod into 5 focused helper methods:_handle_embedded_url_credentials_get_auth_plugin_process_auth_with_plugin_process_netrc_credentials_finalize_authenticationMoved
check_optionsfunction from_process_output_optionsto class level as_check_optionsAdded type annotations to method signatures
Reduced cyclomatic complexity from ~20 to ~5 per method
Eliminated duplicated code patterns
Impact
The changes are backward compatible and don't alter any public APIs.