Skip to content

Fix SSL certificate loading on macOS systems #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vinayK34 wants to merge 1 commit into from
Closed

Fix SSL certificate loading on macOS systems #1928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion httpie/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
cookiejar.DefaultCookiePolicy = HTTPieCookiePolicy

is_windows = 'win32' in str(sys.platform).lower()
is_macos = 'darwin' in str(sys.platform).lower()
is_frozen = getattr(sys, 'frozen', False)

MIN_SUPPORTED_PY_VERSION = (3, 7)
Expand Down Expand Up @@ -110,4 +111,19 @@ def ensure_default_certs_loaded(ssl_context: SSLContext) -> None:
"""
if hasattr(ssl_context, 'load_default_certs'):
if not ssl_context.get_ca_certs():
ssl_context.load_default_certs()
# On macOS, we need to ensure certificates are loaded properly
# This fixes the issue where SSL certificates aren't loaded correctly
# on macOS systems, causing "CERTIFICATE_VERIFY_FAILED" errors
try:
ssl_context.load_default_certs()
except Exception:
# If load_default_certs fails, try alternative approaches
# For macOS specifically, we might need to use certifi
if is_macos:
try:
import certifi
ssl_context.load_verify_locations(certifi.where())
except ImportError:
# If certifi is not available, we can't do much more
# The error will be raised by the SSL context when needed
pass
Loading