Fix test_lazy_choices_help failing on Python 3.14 - #1904
Open
vtino17 wants to merge 2 commits into
Open
Conversation
Initialize _help before super().__init__ to prevent argparse from triggering getter() during Action initialization, which breaks the lazy loading contract. Fixes httpie#1641
Author
|
I corrected the Python 3.14 fix in commit 0685ac0. Python 3.14 validates action help after the action constructor returns, so initializing _help before super() was insufficient. The updated implementation skips exactly that initial eager validation when _check_help exists, while preserving lazy help generation. The existing regression expectations now pass under Python 3.14.6: neither the choices getter nor help formatter is called during parser initialization, and help rendering still calls the formatter once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1641
Problem
Python 3.14 validates an argparse action's help immediately after constructing the action. That eager read caused
LazyChoices.helpto load choices during parser initialization, breaking the lazy contract.Change
_check_helpvalidation pathValidation
Tested with Python 3.14.6: