CLI: allow excess arguments for htmlhint #1837
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,7 +50,7 @@ | |
| }, | ||
| "dependencies": { | ||
| "async": "3.2.6", | ||
| "commander": "14.0.3", | ||
| "glob": "^13.0.6", | ||
| "is-glob": "^4.0.3", | ||
| "node-sarif-builder": "4.0.0", | ||
|
|
@@ -74,9 +74,9 @@ | |
| "jest": "^30.3.0", | ||
| "parse-glob": "3.0.4", | ||
| "prettier": "3.8.1", | ||
| "rimraf": "^6.1.3", | ||
| "rollup": "4.59.1", | ||
| "typescript": "5.9.3" | ||
|
Comment on lines
76
to
+79
There was a problem hiding this comment.
|
||
| }, | ||
| "engines": { | ||
| "node": ">=20" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,6 +28,7 @@ function map(val: string) { | |
| } | ||
|
|
||
| const program = new Command() | ||
| program.allowExcessArguments(true) | ||
|
There was a problem hiding this comment. This change alters how the CLI tolerates additional positional args, but there’s no regression test covering the new behavior. Please add a CLI-level test (e.g., invoking
Contributor
There was a problem hiding this comment. While I suggest removing this line and instead adding // src/cli/htmlhint.ts:56
program
.version(pkg.version)
.usage('<file|folder|pattern|stdin|url ...> [options]')
.argument('[targets...]', 'file, folder, pattern, stdin, or url to lint') // Add this line
.option('-l, --list', 'show all of the rules available')
// ...This will have the same effect of allowing multiple file/path arguments, but it is more explicit about the command's interface. |
||
|
|
||
| program.on('--help', () => { | ||
| console.log(' Examples:') | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commanderis bumped from 11.x to 14.x as part of this change. Since this is a runtime dependency for the published CLI, a major-version upgrade can introduce unrelated breaking behavior; consider either keeping the existing major version (ifallowExcessArgumentsis available there) or splitting thecommanderupgrade into a dedicated PR with explicit compatibility/testing notes.