Repository navigation
fix(ci): install pnpm without corepack in the browser jobs - #68
Merged
Merged
Conversation
The browser jobs in ci.yml and release.yml started failing at their first step with "corepack: not found". The playwright:v1.64.1-noble tag was re-published (digest sha256:2f05f8a7...) and now ships Node 26.13.0, and Node stopped bundling corepack in 25. Nothing in the repo changed; any pull request or release run hits it. npm install -g corepack is not a way back: its yarn shims collide with the yarn the image already installs (EEXIST /usr/bin/yarnpkg). So the two container jobs install pnpm 11.1.3 from npm directly, the same pinned version. The other jobs run setup-node 22, which still bundles corepack, and keep it. Tags: #ci Co-Authored-By: htjulia <htjulia1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser jobs in ci.yml and release.yml started failing at their
first step with "corepack: not found". The playwright:v1.64.1-noble
tag was re-published (digest sha256:2f05f8a7...) and now ships Node
26.13.0, and Node stopped bundling corepack in 25. Nothing in the
repo changed; any pull request or release run hits it.
npm install -g corepack is not a way back: its yarn shims collide
with the yarn the image already installs (EEXIST /usr/bin/yarnpkg).
So the two container jobs install pnpm 11.1.3 from npm directly, the
same pinned version. The other jobs run setup-node 22, which still
bundles corepack, and keep it.
Verification
In
mcr.microsoft.com/playwright:v1.64.1-nobleat the digest CI now pulls (Node 26.13.0), on a clean copy of the tracked files:npm install -g pnpm@11.1.3→pnpm -vis 11.1.3pnpm install --frozen-lockfile— cleanpnpm test:browser— 477 tests passThe failing run this fixes: https://github.com/htcom-code/hexcanvas/actions/runs/41366290165 (on #67, whose other jobs pass).