Merged
Conversation
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
|
|
||
| public Class<?> getType() { | ||
| return type == null ? dataType.getJavaType() : type; |
There was a problem hiding this comment.
Bug: Null Pointers: Inconsistent Null Handling.
The getType() method can throw NullPointerException when type is null and dataType is also null, since it calls dataType.getJavaType() without null-checking dataType. The @NonNull annotation was removed from the dataType field, allowing null values, but the getter doesn't handle this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Make CLOB encoding/decoding and null handling column-aware, replacing ClobValue with LongCharSequence and updating executors/builders (incl. Oracle) and tests accordingly.
ValueCodec.encodeNull(ColumnMetadata)and use it inAbstractColumnMetadataandrdb/metadata/RDBColumnMetadata.ClobValueCodec: addisClobType, returnNullValuefor column-aware nulls, wrap CLOB text asLongCharSequence.JsonValueCodec: use column-aware nulls andLongCharSequencefor CLOB columns; expand decode support (e.g.,Reader, typed blobs) and handle null targets.LongCharSequencereplaces prior CLOB wrapper; used for streaming/Clob binding.NullValue: store explicittype, improvegetType()andtoString(), addof(DataType)helper.LongCharSequenceviasetCharacterStream; honorNullValueSQL types.LongCharSequenceasClob; bindNullValueby Java type, special-case CLOB nulls.OracleBatchUpsertOperatorandOracleInsertSqlBuilder: encode values per column; for batched CLOB nulls, substitute emptyLongCharSequenceto avoid null binding.Written by Cursor Bugbot for commit 7e43d63. This will update automatically on new commits. Configure here.