remove unwanted log message#120
Open
integrii wants to merge 2 commits intohpcloud:masterfrom
integrii:remove-unwanted-seek-message
Open
remove unwanted log message#120integrii wants to merge 2 commits intohpcloud:masterfrom integrii:remove-unwanted-seek-message
integrii wants to merge 2 commits intohpcloud:masterfrom
integrii:remove-unwanted-seek-message
Conversation
When you have a nice spinner, this echo screws up output. In general, packages should try to pass output as returns, leaving it up to the main program to decide what to output.
>
> ⠋ Watching for fatal in api.log 2017/05/12 00:00:11 Seeked api.log - &{Offset:0 Whence:2}
> ⠼ Watching for fatal in api.log
Contributor
|
@integrii Thanks for your contribution. I like the change you made and more than happy to merge it in, but can we actually remove the line as oppose to commenting it out? |
Author
|
Done! |
Author
|
Looks like this build exploded for reasons outside of the change. Re-opening request. |
73 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you have a nice program with a spinner watching a file, this print ruins the output. In general, packages should avoid printing to console and instead return output so that the decision to display output can be made upstream. For now, it would make sense to pull this message out.
Example: