This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Open
Conversation
Since there's no 4.15 published, an `npm install` fails in the botbuilder-adapter-slack subpackage.
Motivation: `request` is implicitly depended on by botbuilder-adapter-slack but it's not in package.json. This means we need to either: * Add it as a dependency * Remove it entirely Given `request` is long since deprecated and usage in `botbuilder-adapter-slack` is minimal (just this one request), the latter seems most sensible. Of candidate HTTP clients to swap out, node-fetch seems the obvious choice: * It's very small * It's popular * some of the botbuilder/botkit packages depend on it already
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
requestis implicitly depended on bybotbuilder-adapter-slack but it's not in package.json.
This means we want to either:
Given
requestis long since deprecated and usage inbotbuilder-adapter-slackis minimal (just this one request), thelatter seems most sensible.
Of candidate HTTP clients to swap out, node-fetch seems the obvious choice:
Where I'd like your advice with this PR: