fix(terminal): refit grid after enabling WebGL - #114
Merged
Merged
Conversation
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a terminal card switched from the DOM renderer to WebGL, xterm kept the grid fitted for the DOM cell width. WebGL snaps cells to device pixels, so the existing PTY dimensions could leave a visible empty strip on the right and make the terminal appear narrowed.
Change
Refit the terminal immediately after WebGL is attached, using the existing fit and PTY resize path. DOM and WebGL renderer transitions now both fit with the active renderer.
Validation
npm test— 1282 passed, 0 failed, 2 skipped.npm run typecheck— passed.npm run build— passed.stty sizereported29 123; repeated renderer cycles, scrollback, alternate screen, focus, context loss, and teardown passed with no console or renderer errors.