feat/modernize#2
Merged
Merged
Conversation
Member
ralflang
commented
May 8, 2025
- feat: Drop dependency on horde/test and use PHPUnit 11 directly.
- fix: Made tests compatible with PHPUnit 12. Removed one test which was an unconditional skip for multiple years
- style: Apply php-cs-fixer
- Add rule for implicitly nullables
- fix: Implicitly nullable parameters are not explicitly nullable
- fix: Removed guards no longer necessary due to signatures or new PHP behaviour >= 8.2
- style: Turn annotations into attributes
- ci: Don't run phpstan on test dir in the mandatory step but only in the allowed-to-fail step
…s an unconditional skip for multiple years
…he allowed-to-fail step
Member
Author
|
@TDannhauer I don't strictly need a review here but this is quite an instructional PR on the chores we do
It's not necessary to do everything in one PR. For example, multiple libraries now run phpstan twice. First pass with level 5 makes the pipeline fail. Second pass with level 9 just complains but does not make the pipeline fail. CC @Schlue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.