Skip to content

fix: enforce SQS 1 MB batch byte limit #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexluong wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix: enforce SQS 1 MB batch byte limit #845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion internal/mqs/queue_awssqs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,14 @@ import (
"github.com/aws/aws-sdk-go/aws"
"gocloud.dev/pubsub"
"gocloud.dev/pubsub/awssnssqs"
"gocloud.dev/pubsub/batcher"
)

// sqsMaxBatchBytes is the maximum total payload size for an SQS SendMessageBatch
// request. SQS rejects batches exceeding 256 KB per message and 1 MB per batch.
// Setting this on the gocloud batcher prevents oversized batches from being sent.
const sqsMaxBatchBytes = 1_048_576 // 1 MB

type AWSSQSConfig struct {
Endpoint string // optional - dev-focused
Region string
Expand Down Expand Up @@ -56,7 +62,11 @@ func (q *AWSQueue) Init(ctx context.Context) (func(), error) {
if err != nil {
return nil, err
}
q.topic = awssnssqs.OpenSQSTopicV2(ctx, q.sqsClient, q.sqsQueueURL, nil)
q.topic = awssnssqs.OpenSQSTopicV2(ctx, q.sqsClient, q.sqsQueueURL, &awssnssqs.TopicOptions{
BatcherOptions: batcher.Options{
MaxBatchByteSize: sqsMaxBatchBytes,
},
})
return func() {
q.topic.Shutdown(ctx)
}, nil
Expand Down
Loading