Skip to content

docs: Align the ServeStaticOptions comment with the current spec#356

Merged
yusukebe merged 1 commit into
honojs:mainfrom
kakkokari-gtyih:kakkokari-gtyih-patch-1
May 17, 2026
Merged

docs: Align the ServeStaticOptions comment with the current spec#356
yusukebe merged 1 commit into
honojs:mainfrom
kakkokari-gtyih:kakkokari-gtyih-patch-1

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 17, 2026

What

Modified the JSDoc comment on ServeStaticOptions.root to current spec (relative/absolute paths are both supported).

Why

Fix #355

@kakkokari-gtyih kakkokari-gtyih changed the title fix: Align the ServeStaticOption command with the current spec fix: Align the ServeStaticOptions command with the current spec May 17, 2026
@kakkokari-gtyih kakkokari-gtyih changed the title fix: Align the ServeStaticOptions command with the current spec fix: Align the ServeStaticOptions comment with the current spec May 17, 2026
@yusukebe yusukebe changed the title fix: Align the ServeStaticOptions comment with the current spec docs: Align the ServeStaticOptions comment with the current spec May 17, 2026
Copy link
Copy Markdown
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Copy Markdown
Member

@kakkokari-gtyih

Thank you for the quick fix. Looks good!

@yusukebe yusukebe merged commit cee5e81 into honojs:main May 17, 2026
5 checks passed
@kakkokari-gtyih kakkokari-gtyih deleted the kakkokari-gtyih-patch-1 branch May 17, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSDoc for ServeStaticOptions seems not updated

2 participants