Repository navigation
Fix import refresh and add GitHub PR review - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the crash when refreshing project imports and provide one deduplicated list ordered by recent tool activity. Discovery runs explicitly when opening or refreshing Import, preserves user selection, and ignores stale or cancelled scans. Repositories in system temporary directories are excluded across all discovery sources, including cached results and symlink aliases; manual opening and already-added projects remain available.
Add a fixed project header with a Worktrees / Pull requests toggle. The GitHub view uses Octocrab 0.54.5 with the existing GitHub CLI login, lists open PRs and drafts by latest update, and offers shortened tabs, searchable overflow, pagination, and remote selection. PR patches use the existing diff viewer in read-only mode; local checkout selections and reading positions survive switching modes.
GitHub requests run off the UI thread on a shared Tokio runtime. Generation checks discard stale responses; preview keys include repository, PR, and commit IDs. Previews share the bounded cache, keep the selected file available after cache eviction, and reject oversized patches. Errors support retry and opening the PR in GitHub. GitHub.com only; review comments, approvals, merge, and checkout are outside this change.
Validation:
cargo test --locked --features ui-testssuite passed, including import refresh/cancellation, worktree restoration, staging, native rendering, and watcher checks.cargo clippy --locked --all-targets --features ui-tests -- -D warnings, formatting, and whitespace checks passed.Temporary-repository follow-up: all 17 discovery tests and the native import UI test passed, including cached scans, component-aware path matching, symlinks, and manual opening of a temporary checkout. Clippy, formatting, and whitespace checks passed.
PR loading feedback: compact accessible status labels and spinners cover initial listing, refresh, individual diffs, and pagination. Refresh retains the current tabs and diff, Load more shows its own busy state, and errors/cancellation clear the indicators. Native GitHub UI tests, Clippy, formatting, and the local build passed. Large-list rendering and pagination behavior are unchanged.