Repo health: modernize deps, security, tests, docs - #28
Merged
Merged
Conversation
- Add Maven build with JavaFX 21 and JUnit 5 - Restructure to src/main/java and src/test/java - Decouple game logic from UI; fix main(), autoplay thread, empty grid input - Add Spotless formatting, GitHub Actions CI, Dependabot - Add MIT LICENSE, SECURITY.md, README, and .editorconfig Co-authored-by: Joel Town Road <vision2020joel@gmail.com>
Co-authored-by: Joel Town Road <vision2020joel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes randobotjava (JavaFX treasure-hunt game) for Java 21, Maven, automated CI, and maintainability while preserving gameplay.
Security
SECURITY.mdwith reporting guidance..gitignore(removed the blanket*.ymlignore that blocked CI/Dependabot configs).Dependencies and runtime
maven.compiler.release.src/main/java,src/test/java; removed hand-maintainedMETA-INF/MANIFEST.MF.Working code
main()→Application.launch.Platform.runLater(avoids freezing the JavaFX thread).NumberFormatException.System.exit(69)withPlatform.exit()for cleaner JavaFX shutdown.GamefromViewviaGameBoardListener(enables headless unit tests).makeMove,getStatus, etc.) and improvedPoint.hashCode.Tests and linting
PointTest,GameTest) — offline, no credentials.mvn spotless:checkin CI.CI
push/pull_requesttomaster.License
README
General polish
.editorconfigadded.target/and standard Java ignores.Skipped / N/A
Verification (local)
Tests run: 5, Failures: 0
Owner actions
None required for secrets. Use JDK 21+ and
mvn javafx:runto play locally.