fix: make CapturedRange start/end date filters inclusive - #27
Merged
Conversation
Serialize calendar dates only and advance the exclusive API end bound by one day so same-day filters (e.g. 07–07) cover the full day instead of collapsing to an empty midnight-to-midnight window. Co-authored-by: Welbert Castro <welberthime@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same-day
captured_rangefilters (e.g. start=2024-01-07, end=2024-01-07) were serialized as identical midnights (…T00:00:00.000Z,…T00:00:00.000Z). The GoPro cloud API treats that window as half-open[start, end), so the result was an empty media array.Changes
CapturedRange._serialize_captured_range, use the calendar date portion only (also fixes a double-Tbug when the datetime already had a time).--start 2026-03-01 --end 2026-03-01for a single day).Example