fix: redis parameter delayed parsing#5503
Open
unknowndevQwQ wants to merge 1 commit into
Open
Conversation
hiddify#5134 In the command of docker-compose.yml, the single $ environment variable will be parsed on the host and executed directly in the container, and env_file does not participate in the parsing process, which causes the redis password to be actually empty. There are two solutions, one of which is to rename docker.env to .env. Another solution is to add an additional $ to the environment variables that need to be parsed within the container, which will cause the corresponding variables to be parsed within the container. Both solutions can meet the requirement that redis needs to obtain the password from the environment variable passed in the parameter. fix: hiddify#5134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5134
In the command of docker-compose.yml, the single $ environment variable will be parsed on the host and executed directly in the container, and env_file does not participate in the parsing process, which causes the redis password to be actually empty. There are two solutions, one of which is to rename docker.env to .env. Another solution is to add an additional $ to the environment variables that need to be parsed within the container, which will cause the corresponding variables to be parsed within the container. Both solutions can meet the requirement that redis needs to obtain the password from the environment variable passed in the parameter.
fix: #5134