HHH-19912 Add automatic test data cleanup feature to @SessionFactory annotation #11203
+344
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inpink
force-pushed
the
inpink/HHH-19912
branch
2 times, most recently
from
ea9ba16 to
374fdb8
Compare
sebersole
reviewed
Nov 6, 2025
Comment on lines
261
to
271
| final Optional<SessionFactory> sfAnnRef = AnnotationSupport.findAnnotation( | ||
| context.getRequiredTestClass(), | ||
| SessionFactory.class | ||
| ); | ||
|
|
||
| if (sfAnnRef.isPresent()) { | ||
| DropDataTiming configuredTiming = sfAnnRef.get().dropTestData(); | ||
| if (configuredTiming == timing) { | ||
| scope.dropData(); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
IMO, it would be better to keep track of this "drop timing" as the SessionFactory annotation is discovered on the class / method and kept in the JUnit ExtensionContext.Store.
See FailureExpectedExtension for an example of how we do this alsewhere.
Author
There was a problem hiding this comment.
Thank you for the helpful guidance! I’ll finish the revisions soon and mention you again.
Author
There was a problem hiding this comment.
@sebersole I’ve finished preparing the PR. Could you please review it when you have a moment? Thanks a lot!
inpink
force-pushed
the
inpink/HHH-19912
branch
3 times, most recently
from
786f305 to
ad5c292
Compare
inpink
force-pushed
the
inpink/HHH-19912
branch
from
ad5c292 to
02679d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19912