fix(cli): bound website capture and reject blocked pages - #2927
Closed
miguel-heygen wants to merge 7 commits into
Closed
fix(cli): bound website capture and reject blocked pages#2927miguel-heygen wants to merge 7 commits into
miguel-heygen wants to merge 7 commits into
Conversation
Comment on lines
+302
to
+317
| body: JSON.stringify({ | ||
| model, | ||
| messages: [ | ||
| { | ||
| role: "user", | ||
| content: [ | ||
| { type: "text", text: prompt }, | ||
| { | ||
| type: "image_url", | ||
| image_url: { url: `data:${mimeType};base64,${base64}` }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| max_tokens: maxTokens, | ||
| }), |
3 tasks
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Website capture no longer reports success for a minimal protection page or waits indefinitely on optional enrichment. Strong, structurally minimal 401/403/429/challenge responses now fail immediately, while vision, font, asset, media, screenshot, and contact-sheet work share a cooperative post-navigation budget with explicit degraded outcomes.
This addresses two related capture-path failures without conflating them:
403 - Forbidden, 50 characters, zero sections. The CLI previously exited 0 and deferred the failure to EF's frame builder.AbortSignal, successful siblings are retained, and phase breadcrumbs identify the last stage.Design decisions
--capture-budgetis distinct from the navigation--timeout; it is cooperative and intentionally does not claim to interrupt already-started native Sharp/Puppeteer work.--skip-visiongives callers a deterministic way to omit optional captions.Verification
https://fujicosmeticink.com/#about: HTTP 403 /403 - Forbidden/ 50 chars, actionable JSON error, exit 1 in 4.6 seconds before extraction.Linear: STUDIO-5419
Experiment Framework boundary/diagnostics: experiment-framework#44091