test(spaces): pin spaces:info --json generation_object shape - #3884
Open
michaelmalave wants to merge 2 commits into
Open
test(spaces): pin spaces:info --json generation_object shape#3884michaelmalave wants to merge 2 commits into
michaelmalave wants to merge 2 commits into
Conversation
Assert the migrated 3.sdk --json wire shape: generation as a string plus the
:v3_sdk serializer's generation_object ({id, name}). The fixture attaches
generation_object via a cast (the hyperschema doesn't declare it) so a
regression to the old object-only generation shape fails the test.
Ref: W-23943907 (eablack #3881 review #5)
Fixes the spell-check CI failure on PR #3884: the new comment in info.unit.test.ts uses the domain term "hyperschema", which the project dictionary didn't yet contain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the migrated
spaces:info --jsonwire shape with a regression test so a revert to the pre-@heroku/sdkobject-onlygenerationshape fails. Test-only; no runtime or changelog change.shows space info --jsonfixture to the3.sdkshape:generationas a string plus ageneration_object: {id, name}.generation_objectvia anas SpaceWithOutboundIpscast inside the test (the:v3_sdkserializer emits it at runtime but the hyperschema doesn't declare it) — the type is not extended.--jsonpreserves both fields verbatim.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes: The changed file type-checks clean. Note a pre-existing, unrelated whole-project
tsc -p testfailure insrc/commands/spaces/vpn/wait.ts+ its test (missing@heroku/sdk/extensions/platformexports) that predates this branch — it is not introduced here and does not touchspaces:info.Steps:
npx mocha test/unit/commands/spaces/info.unit.test.ts— Expect: 7 passing (incl.shows space info --json).npx tsc -p test --noEmit 2>&1 | grep "commands/spaces/info"— Expect: empty (no type errors in the changed file).Screenshots (if applicable)
Related Issues
GitHub issue: follow-up from review of #3881 (point #5)
GUS work item: W-23943907