feat: add data:pg:get-ca - #3880
Draft
jdowning wants to merge 2 commits into
Draft
Conversation
ekozilforce
reviewed
Aug 21, 2026
Comment on lines
+40
to
+44
| if (process.platform === 'win32') { | ||
| if (!process.env.APPDATA) throw new Error('APPDATA is not set; unable to determine the PostgreSQL certificate directory.') | ||
|
|
||
| return path.join(process.env.APPDATA, 'postgresql') | ||
| } |
Contributor
There was a problem hiding this comment.
destinationDirectory is stubbed in all tests, so nothing truly exercises this code path in ci. I guess it will likely work... should we have a flag for customers to define the destination directory in case of issues or alternative install directories?
Contributor
There was a problem hiding this comment.
Re: the stubbing, maybe we just don't stub the destinationDirectory. We test across windows, osx, ubuntu boxes and I think this may "just" work unstubbed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
data:pg:get-cacommand to help assist customers with obtaining the certificate authority for Essential and Advanced Postgres. This will permit verifiable TLS client connections.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Steps:
Screenshots (if applicable)
Related Issues
GitHub issue: #[GitHub issue number]
GUS work item: [WI number](WI link)