fix: pass empty string to rl.write in repl finally block (W-22295448)#3721
Open
heroku-johnny wants to merge 1 commit into
Open
fix: pass empty string to rl.write in repl finally block (W-22295448)#3721heroku-johnny wants to merge 1 commit into
heroku-johnny wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
heroku-johnny
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
heroku-johnny
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a TypeError thrown by rl.write(null, ...) in the REPL's finally block. Node's readline/promises interface requires a string as the first argument.
Type of Change
[X] fix: Bug fix
Testing
or
Build first
npm run buildLaunch the REPL
./bin/run replThen at the heroku > prompt, run any valid command (e.g. apps:info --app ), and prompt returns cleanly
Related Issues
Github Issue: #3684
GUS work item: W-22295448