Skip to content

feat(acpi): support shutdown of HW-reduced ACPI platforms - #2668

Draft
mkroening wants to merge 13 commits into
mainfrom
acpi-shutdown
Draft

feat(acpi): support shutdown of HW-reduced ACPI platforms#2668
mkroening wants to merge 13 commits into
mainfrom
acpi-shutdown

Conversation

@mkroening

Copy link
Copy Markdown
Member

This makes our ACPI shutdown procedure more conformant and adds support for shutting down HW-reduced ACPI platforms such as Cloud Hypervisor.

Closes #2649.

Depends on:

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: d2e3005 Previous: 2e23902 Performance Ratio
startup_benchmark Build Time 94.98 s 80.34 s 1.18
startup_benchmark File Size 1.06 MB 0.80 MB 1.33
Startup Time - 1 core 0.77 s (±0.02 s) 0.75 s (±0.02 s) 1.03
Startup Time - 2 cores 0.76 s (±0.02 s) 0.74 s (±0.02 s) 1.03
Startup Time - 4 cores 0.78 s (±0.01 s) 0.74 s (±0.02 s) 1.05
multithreaded_benchmark Build Time 96.65 s 82.11 s 1.18
multithreaded_benchmark File Size 1.14 MB 0.86 MB 1.33
Multithreaded Pi Efficiency - 2 Threads 65.64 % (±6.66 %) 85.89 % (±6.61 %) 0.76
Multithreaded Pi Efficiency - 4 Threads 40.77 % (±2.63 %) 43.43 % (±2.56 %) 0.94
Multithreaded Pi Efficiency - 8 Threads 20.01 % (±1.54 %) 25.76 % (±1.53 %) 0.78
micro_benchmarks Build Time 215.06 s 80.40 s 2.67
micro_benchmarks File Size 1.15 MB 0.86 MB 1.33
Scheduling time - 1 thread 192.23 ticks (±30.88 ticks) 62.65 ticks (±4.06 ticks) 3.07
Scheduling time - 2 threads 106.12 ticks (±22.52 ticks) 34.08 ticks (±4.10 ticks) 3.11
Micro - Time for syscall (getpid) 9.81 ticks (±5.52 ticks) 3.45 ticks (±0.58 ticks) 2.84
Memcpy speed - (built_in) block size 4096 58170.18 MByte/s (±41419.42 MByte/s) 82448.38 MByte/s (±56997.13 MByte/s) 0.71
Memcpy speed - (built_in) block size 1048576 14077.39 MByte/s (±11487.95 MByte/s) 30585.98 MByte/s (±24707.84 MByte/s) 0.46
Memcpy speed - (built_in) block size 16777216 11966.47 MByte/s (±9934.30 MByte/s) 26340.06 MByte/s (±21720.96 MByte/s) 0.45
Memset speed - (built_in) block size 4096 58348.26 MByte/s (±41535.44 MByte/s) 82292.76 MByte/s (±56891.50 MByte/s) 0.71
Memset speed - (built_in) block size 1048576 14455.24 MByte/s (±11681.88 MByte/s) 31323.85 MByte/s (±25145.86 MByte/s) 0.46
Memset speed - (built_in) block size 16777216 12307.32 MByte/s (±10128.61 MByte/s) 27104.68 MByte/s (±22209.94 MByte/s) 0.45
Memcpy speed - (rust) block size 4096 53923.16 MByte/s (±38655.30 MByte/s) 74097.96 MByte/s (±51811.44 MByte/s) 0.73
Memcpy speed - (rust) block size 1048576 14143.22 MByte/s (±11779.89 MByte/s) 30361.60 MByte/s (±24602.37 MByte/s) 0.47
Memcpy speed - (rust) block size 16777216 12344.29 MByte/s (±10312.17 MByte/s) 27625.34 MByte/s (±22806.88 MByte/s) 0.45
Memset speed - (rust) block size 4096 54304.40 MByte/s (±38904.29 MByte/s) 74373.47 MByte/s (±51976.48 MByte/s) 0.73
Memset speed - (rust) block size 1048576 14429.25 MByte/s (±11947.13 MByte/s) 31110.89 MByte/s (±25033.24 MByte/s) 0.46
Memset speed - (rust) block size 16777216 12670.70 MByte/s (±10507.41 MByte/s) 28386.93 MByte/s (±23265.03 MByte/s) 0.45
alloc_benchmarks Build Time 215.72 s 74.76 s 2.89
alloc_benchmarks File Size 1.13 MB 0.87 MB 1.30
Allocations - Allocation success 91.35 % 91.31 % 1.00
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 61.59 % 61.44 % 1.00
Allocations - Average Allocation time 24848.02 Ticks (±1360.27 Ticks) 5860.58 Ticks (±98.43 Ticks) 4.24
Allocations - Average Allocation time (no fail) 25862.46 Ticks (±1760.24 Ticks) 6554.81 Ticks (±92.86 Ticks) 3.95
Allocations - Average Deallocation time 7317.99 Ticks (±1837.55 Ticks) 1805.01 Ticks (±250.35 Ticks) 4.05
mutex_benchmark Build Time 210.94 s 79.82 s 2.64
mutex_benchmark File Size 1.15 MB 0.86 MB 1.33
Mutex Stress Test Average Time per Iteration - 1 Threads 36.00 ns (±6.09 ns) 12.10 ns (±0.41 ns) 2.98
Mutex Stress Test Average Time per Iteration - 2 Threads 31.56 ns (±8.13 ns) 40.26 ns (±1.68 ns) 0.78

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modern ACPI shutdown is missing

1 participant