Fix compilation issue for LruCache::operator-- #1652
Merged
+45
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1652 +/- ##
==========================================
- Coverage 80.33% 80.31% -0.03%
==========================================
Files 350 350
Lines 14039 14040 +1
Branches 1515 1515
==========================================
- Hits 11278 11275 -3
- Misses 2147 2149 +2
- Partials 614 616 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mykolamalik
force-pushed
the
task/nlam-182
branch
from
c6d21c3 to
7a2a482
Compare
Struct LruCache::Bucket doesn't have a member called m_previous. Besides the logical changes (2 lines, `m_previous`->`previous_`), this commit also includes quite a few fixes of clang-format complaints. This file hasn't been reformatted earlier, as the last update of this file was done in 2021. Relates-To: NLAM-182 Signed-off-by: Mykola Malik <ext-mykola.malik@here.com>
mykolamalik
force-pushed
the
task/nlam-182
branch
from
7a2a482 to
1abd094
Compare
mykolamalik
requested review from
andrey-kashcheev,
asopov-here,
khomenkd and
rustam-gamidov-here
rustam-gamidov-here
approved these changes
Dec 29, 2025
andrey-kashcheev
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Struct LruCache::Bucket doesn't have a member called m_previous.
Besides the logical changes (2 lines,
m_previous->previous_), this commit also includes quite a few fixes of clang-format complaints. This file hasn't been reformatted earlier, as the last update of this file was done in 2021.Relates-To: NLAM-182