Conversation
e1a9ee3 to
9f7dc32
Compare
helsome
left a comment
There was a problem hiding this comment.
方向和增量 scope 我认可:保留 payload-only 兼容接口,单独接 quote provenance,并明确不关闭 #101;也尊重你对 #101 的认领,不要求补 #106 或重做 Source Inspector。当前只缺两项合入证据:
- 补齐可复现报告:实际 Bun 版本、OS,以及“38 passed”的完整 focused 命令。说明这些结果对应当前 head,失败/跳过有则列出。
- 按本项目已更新的真实接入验收规则,补一次这条 quote 路径的真实验证:真实模型/Pi → 正常工具/Capability → 已配置的真实金融 Provider → 回答和持久化 financialEvidence → reload。列出命令、query、model、实际 provider、run/tool id、真实返回值摘要、canonical instrumentId、asOf/retrievedAt(标清单位)、delayed/stale,并证明重载后保持一致。无需新 UI、截图或大型 E2E 框架。
我已读 acceptance test:其中 FakeFinancialDataProvider、ScriptedRuntime,以及手工组装的 structuredResult 验证了确定性接线,但没有验证真实 Pi tool-result 传输边界,不能称为真实数据验收。现有 fallback fixture 测试保留且有价值;只需把它标为受控/fixture 路径,不要求等外部供应商自然故障。若声称真实双 Provider fallback 已通过,则需另外提供对应真实成功路径。
9f7dc32 to
147042a
Compare
|
Thanks for the review. I rebased the branch onto upstream The PR description now has the exact Bun/Windows environment, focused command and result ( I also added I am not claiming the live run passed yet: this host currently has no |
|
Live validation is now complete on current head Command: $env:Path = "$env:LOCALAPPDATA\Programs\longbridge;$env:Path"
& 'C:\Users\seven\AppData\Local\Microsoft\WinGet\Packages\Oven-sh.Bun_Microsoft.Winget.Source_8wekyb3d8bbwe\bun-windows-x64\bun.exe' apps/electron/e2e/quote-provenance-live-acceptance.tsEnvironment: Bun The real run used query Evidence:
The PR body contains the full reproducible report and clarifies that the older FakeFinancialDataProvider/ScriptedRuntime path remains a controlled fixture only. No real fallback claim is made. |
Summary
Scope
This is the non-UI quote increment for #101. It does not duplicate #106 answer-trace contract or #30 Source Inspector UI work. The issue remains referenced rather than auto-closed because those complementary slices are outside this PR.
Reproducible validation (current head)
Head:
c94ec59(test: allow cold Pi startup in live acceptance), rebased onto upstreammain8d0ac3a.Environment:
1.4.2(bun v1.4.2 (744846f84)).26100(10.0.26100).Focused command (PowerShell):
Result on current head:
38 passed,0 failed,0 skipped(108 expect()calls).Core/shared regression command:
Result:
983 passed,0 failed(3747 expect()calls).Typecheck command:
Result on current head: core, i18n, shared, ui, and electron passed.
Failures/skips: none in the focused or core/shared commands above.
Quote acceptance evidence
The existing
packages/shared/src/kernel/quote-provenance-acceptance.test.tsis explicitly labeled controlled fixture. It verifies deterministic ProviderRouter fallback, agent tool wiring, persistence, and reload; it does not claim live model or external-provider data.The live command actually run was:
Live preflight:
longbridge auth status --format jsonreported a valid token;longbridge check --format jsonreported the active CN endpoint connected. No demo/fake/shim data was used.Live result (artifact
verification.json, headc94ec5918cf93718f173acb468bc25a0e502a8cc):Use the get_quote finance tool exactly once for AAPL.US. Do not call any other finance or web tool. Report the returned last price and identify the actual data provider, canonical instrumentId, retrievedAt and asOf timestamps, and delayed/stale flags. Use only the tool result; do not invent or estimate missing fields.anthropic, modeldeepseek-v4-pro.longbridge/Longbridge.ece81ffd-46f2-4085-9638-9b958d4d9b3b.79cb9019-82c9-46f2-a876-aa482c6e9968.get_quote; tool idcall_00_8NcN0D4VCHSDiATIxalg2013.AAPL.US, last price332.41, change+1.07000000000005(+0.32293112814633007%), volume35,981,000, high335.48, low330.70, open332.53, previous close331.34.XNAS:AAPL.asOf:1789625194000epoch milliseconds (2026-09-17 14:06:34 UTC). The raw provider timestamp was1789625194epoch seconds and was normalized to milliseconds for evidence.retrievedAt:1789625194966epoch milliseconds (2026-09-17 14:06:34.966 UTC).delayed: false;stale: false;cacheHit: false.fe_866148d1ce85899d9c9be024, capabilitymarket.quote, providerlongbridge.MessageRepositoryreload matched the original evidence exactly:reloadMatches: true.No visible UI changes; screenshot not applicable.