feature/http-gzip-index.yaml - #32478
Open
rafal-prasal wants to merge 1 commit into
Open
Conversation
pull-request-size
Bot
added
the
size/M
github-actions
Bot
added
the
v4.x
Signed-off-by: Rafal Prasal <rafal.prasal@gmail.com>
rafal-prasal
force-pushed
the
feature/http-gzip-index.yaml
branch
from
July 27, 2026 12:14
77d2038 to
24a980a
Compare
Author
|
this resolves #32479 |
Author
|
this is pull request i created. i believe it is more compliant with HTTP headers behaviour |
gjenkins8
reviewed
Jul 28, 2026
| return nil, err | ||
| } | ||
|
|
||
| isRepositoryIndexRequest := isRepositoryIndexRequestURL(href) |
Member
There was a problem hiding this comment.
Please use an option e.g. WithAcceptCompression() so the caller may specify compression should be enabled, rather than "hard-coding" index.yaml.
gjenkins8
requested changes
Jul 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves chart repository index downloads by enabling transparent gzip compression support for index.yaml fetches, reducing network transfer size when servers support Content-Encoding: gzip.
Changes:
- Add
Accept-Encoding: gzipforindex.yamlHTTP requests and transparently decompress gzipped responses. - Add a repository-level test covering gzipped
index.yamldownloads.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/repo/v1/chartrepo_test.go | Adds a test server that serves a gzipped index.yaml and verifies Helm writes the decompressed content to cache. |
| pkg/getter/httpgetter.go | Adds gzip accept/decode logic gated to repository index.yaml requests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+136
to
+140
| gzipWriter := gzip.NewWriter(w) | ||
| defer gzipWriter.Close() | ||
|
|
||
| _, err := gzipWriter.Write(fileBytes) | ||
| require.NoError(t, err) |
Comment on lines
+112
to
+115
| gzipReader, err := gzip.NewReader(resp.Body) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As index.yaml can become big, sending it uncompressed over network becomes a problem.
Fortunately web servers offer compression of content on the fly.
http client must come with proper headers and then server responds accordingly if it supports it.
How it works
client -> "Accept-Encoding: gzip"
server -> "Content-Encoding: gzip"
server -> gzipped content
Special notes for your reviewer:
this solution is completely transparent. it will work only when web server supports it.
it is added only in case of reaching for index.yaml. otherwise httpClient works as before.
If applicable: