fix(action): guard nil RESTClientGetter in CRD install path (dev-v3)#31920
Open
SergioChan wants to merge 1 commit intohelm:dev-v3from
Open
fix(action): guard nil RESTClientGetter in CRD install path (dev-v3)#31920SergioChan wants to merge 1 commit intohelm:dev-v3from
SergioChan wants to merge 1 commit intohelm:dev-v3from
Conversation
pull-request-size
bot
added
the
size/M
Signed-off-by: sergiochan <yuheng9211@qq.com>
SergioChan
force-pushed
the
backport-fix-empty-crd-resources-31552
branch
from
b2454d6 to
711a4ea
Compare
Author
|
Pushed a follow-up commit (force-push) to satisfy the failing DCO check.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Backports the
helm templatepanic fix todev-v3for issue #31552.When CRDs are present,
installCRDsalways dereferencedi.cfg.RESTClientGetterto invalidate discovery/REST mapper caches. InClientOnlyflows this getter can be nil, which caused a nil pointer panic instead of returning a template error.This PR:
i.cfg.RESTClientGetter != nilTestInstallCRDsWithNilRESTClientGetter) to ensure no panic when CRDs exist andRESTClientGetteris nilFixes #31552
Validation
go test ./pkg/action -run "TestInstallCRDsWithNilRESTClientGetter|TestInstallRelease$" -count=1