Repository navigation
cyberpunkunicorn-os 0.1.6: a write on a card that isn't an NTAG says so - #20
Merged
Merged
Conversation
Daniel's 0.1.5 log: the reader works now and saw his card at once, but the card was an ISO 14443-4 card (UID 01020304), not an NTAG. The write selected it again, lost it, and answered 'No card'. A website write now answers 'Not an NTAG213/215/216 tag' when the tapped card isn't one (the console already turns that into 'use an NTAG card or sticker'), and logs what was tapped. A card lost between the tap and the write is reported as a failed write, not as no card. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Aw32AU4vVqCSEoNA5aP3U
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daniel tested 0.1.5. The card reader works now and found his card instantly (
PN532 setup: SAM ok, retries ok). But that card was an ISO 14443-4 card (UID 01020304), not an NTAG. The write selected it again, lost it, and answeredwrite_failed: No card. That made it look like the reader had missed the card.Changes
apps/remote/app_handlers.cpp: if the tapped card is not an NTAG,frequency.write_tagnow fails with "Not an NTAG213/215/216 tag". The console already turns that into "use an NTAG card or sticker". The firmware also logs the type and UID of the tapped card.apps/frequency/card.cpp: ifwriteCard()loses the card between the tap and the write, it now reports a failed write (CARD_WRITE_FAILED) instead of CARD_NONE.build.sh: OS_VERSION is now 0.1.6.Verification
Generated by Claude Code