Repository navigation
cyberpunkunicorn-os: accept m=nfc on placard links, 0.1.1 - #14
Merged
Merged
Conversation
frequency-web writes Space placards as /n/<node>?s=v1...&m=nfc so Scan stats count placard taps, and checkUrl refused any m= on /n/, so every placard write failed. Now m=nfc is allowed on /n/ and added when missing, the same as /q/ (/n reads only s). Any other m= value is still refused. The tag check screen shows the NFC mark for placards too. OS_VERSION 0.1.1 for the next release. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AycPrTRVXqSDZhb2NNfyG6
hellofrequencylab
marked this pull request as ready for review
October 20, 2026 23:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Space placard write failed on 0.1.0. Since frequency-web #3743 the site writes placards as
/n/<node>?s=v1...&m=nfc, so Scan stats count placard taps.checkUrl()refused anym=on/n/.Changes
/n/links now acceptm=nfc, and the board adds&m=nfcwhen it's missing, the same way it does for/q/./nreads onlys, so the signature still checks out. Any otherm=value is still refused.store.hcomments.OS_VERSION0.1.1. After merge, "Run workflow" on main with release ticked publishes cu5k-v0.1.1, and the portal's Update firmware button picks that up.Checked
store.cppandFrequencyMenu.cpptype-check against patched Bruce.frequency.write_tag, the CLI, the menu) writesu.fixed.Generated by Claude Code