Repository navigation
fix(campaigns): isolate platform recipient resolution - #4668
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform audience resolution could include another Space’s private contacts when the same person had a profile. An unknown built-in audience key also fell through to the member audience. This change constrains every platform contact read to Frequency root or legacy-null contacts and makes unknown built-ins resolve to nobody. Missing-root lookup stays restricted to legacy-null contacts.
This is the audience-isolation phase of
SEC-CAMPAIGN-AUDIENCE. The row stays OPEN: separating message purpose from recipient selectors and final production acceptance remain outstanding. The send category, consent/suppression behavior, per-Space campaign implementation, pricing offers and message content are unchanged. No sends, schedules, contact exports, role/provider changes or SQL were performed.The existing canonical row was explicitly transferred out of #4666 (remote head
97b3224b, six files) to this feature; it is not duplicated. Its exact transferred JSON remains open. Daniel specifically approved the existing three-file audience test review. The four-file source/test patch remains byte-identical to the reviewed candidate SHA256d87167ccc5b292661cdae4e0431d8caeb5278eafe0d0dca38e966bc4a9d42851; no additional protected tests, probes, pins, thresholds or baselines change.Validation:
e1e2398de1506ae8eaed200e5713f48f99494fc3. Five-file PR diff, no source/test or ledger-ID overlap with the other seven current open PRs.Exact-head CI, a real READY preview and safe production acceptance remain required. The root driver owns serialized merging and deployment verification; auto-merge must remain off.
Current head:
a802a873239d87a4fc43fac60db0aa71ee7b8b58. Coordination: #4306 (comment).